This repository was archived by the owner on Mar 15, 2023. It is now read-only.
use PIC/PIE on linux-x86-64#464
Merged
Merged
Conversation
|
Contributor
Author
|
Hm. Looks like an temporary apt install of binutils might have been interfering with some builds. That could be contributing. Will monitor. |
Contributor
Author
|
using https://github.com/teaxyz/pantry.extra/actions/runs/4320084201 as my litmus test. this PR might be a good idea regardless, but let's see if its necessary. |
Contributor
|
I think flipping this switch on by default would be good. Let's give it a shot. |
Contributor
Author
|
It's what Ubuntu did. That's a pretty good argument by itself. |
Contributor
Author
|
Yep. Confirmed fix here: pkgxdev/pantry#432 |
Contributor
|
Good sleuthing. I think doing it like superenv on brew is better longer term, but we’ll get to that. |
Contributor
|
A comment would have helped future generations! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu turns on PIC/PIE by default (since 16.04). ChatGPT thinks this might be the fix. I can affirm that it helps a number of segfault issues for different packages.
Testing, you know, needed.
PR/Issuess where this fix was the correct fix: