This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Fix findRelated test, use strings for ids & mock service methods#94
Merged
pixelhandler merged 1 commit intomasterfrom Aug 30, 2016
Merged
Fix findRelated test, use strings for ids & mock service methods#94pixelhandler merged 1 commit intomasterfrom
pixelhandler merged 1 commit intomasterfrom
Conversation
pixelhandler
pushed a commit
that referenced
this pull request
Sep 1, 2016
* deepEqual actual data * Use resource from dummy app model definition * Add unsafe-inline and unsafe-eval CSP * Singularize type in toString() * Use dummy app models; Person->Employee->Supervisor * Add person and supervisor models; use plural types. * Supervisor extends Employee (use EmployeeService), expect singulare type from toString() * Test data-structure, not json string * clean up of adapter/application unit tests * #find() -> casts ids to string, change tests accordingly * Improve adapter error response handling test * removes console.log debug statement * Cast ids to strings at 'public' entry points * Fix findRelated test, use strings for ids & mock service methods (#94) * deepEqual actual data * Use resource from dummy app model definition * Add unsafe-inline and unsafe-eval CSP * Singularize type in toString() * Use dummy app models, Person->Employee->Supervisor * Add person and supervisor models, use plural types * Supervisor extends Employee (use EmployeeService), expect singulare type from toString() * Test data-structure, not json string * Clean up of adapter/application unit tests * #find() -> casts ids to string. Changes tests accordingly * Improve adapter error response handling test * removes console.log debug statement * Cast ids to strings at 'public' entry points * Update fix for incomplete findRelated test * Improve comment * Cast id to string on adapter create- and deleteRelationship. Add tests, improve comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findRelatedtest, https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/addon/models/resource.js#L136-L138cacheLookupwas not stubbed in the adapter/service mock used in the test