This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Closed
Conversation
| type: 'supervisors', | ||
| id: 1000000, | ||
| id: '1000000', | ||
| name: 'The Boss', |
Collaborator
Author
There was a problem hiding this comment.
Should be in key attributes.
Collaborator
Author
|
Owner
|
@aars this code was hiding the flaw in this breaking test, https://github.com/pixelhandler/ember-jsonapi-resources/blob/master/addon/models/resource.js#L136-L138 |
Owner
|
@aars there is a hook that updates the relation after the related proxy resolves.
So yeah I'll create a PR to mixup that test. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one test is broken in an unapparent fashion (for me at least).
This is the only test that breaks after I added my "cast id to string" code. Oddly enough it doesn't have much to do with my changes though, as presented here (cloned from master).
Simply changing the ids to strings (what they MUST be according to JSONAPI) somehow ends up calling
addRelationshipon the resource, and then it breaks.Also, minor and very unrelated issue in payload, the
nameproperty should be part ofattributes.