Test that Unmarshal doesn't do any allocations - #267
Merged
Conversation
jech
force-pushed
the
unmarshal-alloc-test
branch
from
April 15, 2024 19:39
a4d0e77 to
844d5d2
Compare
Member
Author
jech
force-pushed
the
unmarshal-alloc-test
branch
from
April 15, 2024 22:43
844d5d2 to
d7aeff5
Compare
Member
Author
Assert that H264, VP8, VP9 and AV1 don't do any allocation. At this time H265 does allocate.
Sean-Der
force-pushed
the
unmarshal-alloc-test
branch
from
April 23, 2024 04:06
d7aeff5 to
30cf69f
Compare
Sean-Der
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The various Unmarshal functions are low-level functions that
should not do any extensive parsing. Anything that requires
allocations should be done in a user-callable function so that
applications can call Unmarshal without concern for efficiency.