make av1 obu parsing optional - #266
Merged
Merged
Conversation
Closed
jech
force-pushed
the
make-av1-obu-parsing-optional
branch
from
April 15, 2024 16:58
205d7df to
1e05b07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
+ Coverage 86.05% 86.19% +0.14%
==========================================
Files 22 22
Lines 1742 1746 +4
==========================================
+ Hits 1499 1505 +6
+ Misses 206 204 -2
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jech
force-pushed
the
make-av1-obu-parsing-optional
branch
3 times, most recently
from
April 15, 2024 17:07
5eb687f to
ed8f74e
Compare
This was referenced Apr 15, 2024
jech
force-pushed
the
make-av1-obu-parsing-optional
branch
from
April 15, 2024 19:34
ed8f74e to
4da5ba4
Compare
Member
Author
|
I've just made the accessor into a method, so its presence can be tested by callers (by checking whether the packet implements a given interface). I see that H264 and H265 have the same problem, so I've made the name codec-agnostic. |
jech
force-pushed
the
make-av1-obu-parsing-optional
branch
2 times, most recently
from
April 15, 2024 22:35
2c9f7bf to
bcbb9ea
Compare
Make parsing of the OBU list in AV1Packet optional. This enables a higher performance depacketizer, with a reduced feature set.
Sean-Der
force-pushed
the
make-av1-obu-parsing-optional
branch
from
April 23, 2024 03:51
bcbb9ea to
ee561cf
Compare
Sean-Der
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Pion, the (*XXXPacket).Unmarshal operation is supposed to be
fast and perform no allocation, as it is sometimes used to check
just a single flag in the packet header. The AV1Packet
implementation breaks this property by parsing the whole list
of OBUs at Unmarshal time, even though it is likely to be unneeded.
Note that I strongly object to this solution, since it makes the
inefficient path (both in space and in time) the default, and thus
will make people write inefficient code. However, if that's the
cost to getting the brain-damange reverted, I won't scream too
loudly.