docs(Button): combined aria-disabled tooltip examples into single example#7911
docs(Button): combined aria-disabled tooltip examples into single example#7911tlabaj merged 6 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-7911.surge.sh A11y report: https://patternfly-react-pr-7911-a11y.surge.sh |
nicolethoen
left a comment
There was a problem hiding this comment.
This looks good after you delete the old example file.
Although, I have a question for @mcarrano and/or @edonehoo - do you want us to put all disabled + aria-disabled examples together in the button docs?
And I know you didn't update the example titles, but now that there is only one 'aria-disabled' example, you can remove the word 'examples' from the title on line 93
Not sure. @edonehoo what do you think? |
|
Im meaning like location-wise all the examples grouped in the same general area on the page. Not combined into one example |
|
@nicolethoen @mcarrano @edonehoo any updates on this? |
|
Thanks for the poke! I think it makes sense to move them near the other disabled example and update the header. |
|
@nicolethoen @tlabaj how did you say I could go about getting this integration test to work? |
|
@andyyvo try rebasing and see if it passes the next time |
If you click on Details for the failed job, you should be able to restart it. |
|
@andyyvo this is showing a merge conflict, but once that's resolved LGTM |
kmcfaul
left a comment
There was a problem hiding this comment.
Looks good just needs a rebase
thatblindgeye
left a comment
There was a problem hiding this comment.
Other than previous comments and merge conflicts, looks good!
| export const ButtonAriaDisabled: React.FunctionComponent = () => ( | ||
| <React.Fragment> | ||
| <Button isAriaDisabled>Primary aria disabled</Button> <Button isAriaDisabled>Secondary aria disabled</Button>{' '} | ||
| <Button isAriaDisabled>Primary aria disabled</Button>{' '} |
There was a problem hiding this comment.
Once this lint error is resolved we can take it in.
There was a problem hiding this comment.
For some reason, the lint error is simply the new {' '} I added to give spacing between the examples. If I get rid of it, there are no issues. But it makes two of the buttons right next to each other
There was a problem hiding this comment.
hmmm I am not sure why it is complaining about this line in particular since we have {' '} elsewhere.
There was a problem hiding this comment.
I think it is ok to remove it for now. Some of our other examples have the buttons right next to each other.
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #7620 . Just cleaned up the two tooltip examples into one.
Additional issues: