Conversation
In general, we always want to generate IPC client counters, and only disable them when building for targets that don't have the memory to spare. In order to make it harder to accidentally forget to add counters to a new task, this branch changes the feature flags from opting _in_ to generating counters by default, to opting _out_ of generating counters by default.
cbiffle
reviewed
Mar 8, 2024
| pub enum RequestError<E> { | ||
| Runtime(#[cfg_attr(feature = "counters", count(children))] E), | ||
| Fail(#[cfg_attr(feature = "counters", count(children))] ClientError), | ||
| Runtime(#[ount(children)] E), |
cbiffle
approved these changes
Mar 8, 2024
Collaborator
cbiffle
left a comment
There was a problem hiding this comment.
Looks good once it compiles! (Need to set up CI in this repo.)
Since the feature flag now disables, rather than enables, counter code generation, the `idol-runtime` crate's counters support can't be feature flagged. This is fine, since it just enables trait impls, which can easily be dead-code eliminated when they're not used.
Member
Author
gah, thanks for fixing the typo! i started on setting up CI in PR #46, but thus far I haven't actually managed to get |
hawkw
added a commit
that referenced
this pull request
Mar 8, 2024
I really thought I'd pushed this to #47, but it looks like it somehow didn't get pushed --- I had the commit staged all along. My bad. Sorry.
Merged
hawkw
added a commit
that referenced
this pull request
Mar 8, 2024
I really thought I'd pushed this to #47, but it looks like it somehow didn't get pushed --- I had the commit staged all along. My bad. Sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.