Conversation
Currently, this repo doesn't have any kind of CI set up to prevent us from merging broken PRs. This has resulted in mistakes, at least on my behalf (sorry). Therefore, this commit adds a quick CI setup for ensuring that the code compiles and that it's been `rustfmt`ed correctly. We don't currently have any tests for the code in Idolatry, but if we add some in the future, we'll want to add a job to run the tests on CI, as well --- right now, it's just `cargo check` and `cargo fmt`.
There was a problem hiding this comment.
license-eye has totally checked 118 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 0 | 18 | 100 | 0 |
Click to see the invalid file list
- .github/workflows/ci.yml
- .github/workflows/license-check.yml
- .rustfmt.toml
- Cargo.lock
- Cargo.toml
- README.mkdn
- runtime/Cargo.toml
- runtime/src/lib.rs
- rust-toolchain.toml
- src/bin/clienttest.rs
- src/bin/servertest.rs
- src/client.rs
- src/common.rs
- src/counters.rs
- src/lib.rs
- src/serde_helpers.rs
- src/server.rs
- src/syntax.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this repo doesn't have any kind of CI set up to prevent us from merging broken PRs. This has resulted in mistakes, at least on my behalf (sorry). Therefore, this commit adds a quick CI setup for ensuring that the code compiles and that it's been
rustfmted correctly.We don't currently have any tests for the code in Idolatry, but if we add some in the future, we'll want to add a job to run the tests on CI, as well --- right now, it's just
cargo checkandcargo fmt.