#27854 non existing folder skeletondirectory

[Gandolf90]

added new test
throw Exception on false config
catch Exception and write error to Log

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Manually by setting up Owncloud and Creating Admin Account
changed config -> skeleton directory to not existing path
creating new User
logged out
login with new user
-> got loop

changed Code & Tests

Creating new User
login with new user2 -> got blank Owncloud directory without skeleton data.
-> no Loop

Testet with Macbook Pro 15" Early 2011 OS X Sierra High with XAMPP and mysql Database

tests run in Ubuntu 16.04.

-- checked out Core from GitLab and installed MariaDB with NodeJS and PHPUnit
running make & make test

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #29367 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #29367      +/-   ##
============================================
- Coverage     60.23%   60.21%   -0.03%     
- Complexity    17186    17188       +2     
============================================
  Files          1030     1030              
  Lines         57273    57277       +4     
============================================
- Hits          34500    34490      -10     
- Misses        22773    22787      +14

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/util.php	66.66% <100%> (-2.48%)	221 <0> (+1)
lib/private/User/Session.php	63.14% <100%> (+0.52%)	119 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b3388...dedfa8a. Read the comment docs.

[PVince81]

@Gandolf90 can you backport to stable10 ? Create a branch based on stable10, cherry pick your commit, then submit a PR from your branch and set stable10 as target

[phil-davis]

Backport to stable10 in PR #29379

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.