#27854 non existing folder skeletondirectory by Gandolf90 · Pull Request #29250 · owncloud/core

Gandolf90 · 2017-10-15T19:04:09Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

adding throw exception if config false adding new testcase to check if config has incorrekt skeletondirectory

incorrect test-name

CLAassistant · 2017-10-15T19:04:15Z

All committers have signed the CLA.

DeepDiver1975

Thanks a lot for your contribution!
Very welcome!
Please make sure to squash our commits. THX

DeepDiver1975 · 2017-10-16T06:21:34Z

lib/private/legacy/util.php

 		$skeletonDirectory = \OCP\Config::getSystemValue('skeletondirectory', \OC::$SERVERROOT . '/core/skeleton');

+		if(!is_dir($skeletonDirectory))  {
+			throw new OC\HintException('Can not Access to Skeleton Folder, check for right Path in config.php');


please add the value of $skeletonDirectory

test should read as

throw new OC\HintException("The skeleton folder '$skeletonFolder' is not accessible.');

DeepDiver1975 · 2017-10-16T06:22:01Z

tests/lib/UtilTest.php

 	}

+	public function testCopySkeletonDirectory() {
+		$this->expectException(HintException::class);


please use phpunit annotation - see the phpunit docs

DeepDiver1975 · 2017-10-16T06:22:57Z

Please also sign the CLA - see the comment above

added new output added test annotation & check for output

IljaN · 2017-10-18T11:16:26Z

Please reference pull requests to issues like this #27854

IljaN · 2017-10-19T10:43:12Z

tests/lib/UtilTest.php

+	public function testCopySkeletonDirectory() {
+		$notExistingDirectory = '/not/existing/Directory';
+
+		$this->expectException(HintException::class);


You can remove this line if you use the annotation see:
https://phpunit.de/manual/current/en/appendixes.annotations.html#appendixes.annotations.expectedExceptionMessage

IljaN · 2017-10-20T12:58:02Z

lib/private/legacy/util.php


 		$skeletonDirectory = \OCP\Config::getSystemValue('skeletondirectory', \OC::$SERVERROOT . '/core/skeleton');

+		if(!is_dir($skeletonDirectory))  {


Missing space between if and opening parenthesis => if ( )

Missing space between if and opening parenthesis annotation phpunit fixed

IljaN · 2017-10-24T08:52:20Z

@Gandolf90 Some tests are failing, please fix. See Jenkins for details.

removed use tag and added path to Exception Class

added user Folde

mocked userfolder

Gandolf90 · 2017-10-24T20:22:05Z

@IljaN how can I test the failed Selenium/Travis tests?

IljaN · 2017-10-25T10:03:05Z

@Gandolf90 "make test"

added code style space

Gandolf90 · 2017-10-25T13:12:50Z

@IljaN testet local with "make test" and jenkins tests passed
don't know why travis make with php 5.6 settings and selenium error to connect with curl as user

IljaN · 2017-10-25T13:16:56Z

@Gandolf90 Don`t worry our CI is like a diva sometimes :)

phil-davis · 2017-10-25T15:24:09Z

@Gandolf90 Selenium/Travis fails because this is a PR from a forked copy of the repo. So Travis does not provide the job with the authentication keys to the ownCloud SauceLabs account. There are 2 options:

you can ask for access to the ownCloud core repo (which I got as a new community member a few years ago without any hassle) - then clone that and make your own branch in there.
create yourself a SauceLabs open-source free account, then put the details in your own Travis linked to GitHub. Then make a PR of the code in your fork to the master of your fork - Travis and SauceLabs will happily talk using all your own authentication data.

Gandolf90 · 2017-10-25T17:10:15Z

@IljaN or @DeepDiver1975 can you create a temporary access to make the pull request ?

Gandolf90 · 2017-10-25T17:10:42Z

@phil-davis thanks for Hint

IljaN · 2017-10-26T09:04:38Z

@Gandolf90 Why close?

Gandolf90 · 2017-10-26T09:12:02Z

@IljaN Because i wanted to make a Branch from Core Repo and make there the pr as @phil-davis wrote

phil-davis · 2017-10-26T09:41:17Z

@Gandolf90 when you make the PR in core, please mention it here so it is easy to find.

Gandolf90 · 2017-10-26T09:49:13Z

@phil-davis ok

Gandolf90 · 2017-10-26T16:57:47Z

@IljaN @DeepDiver1975 @phil-davis here it goes : #29367

lock · 2019-08-02T04:02:22Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Gandolf90 added 2 commits October 15, 2017 21:01

issue-27854

c078040

adding throw exception if config false adding new testcase to check if config has incorrekt skeletondirectory

issue-27854

40b5173

incorrect test-name

DeepDiver1975 requested changes Oct 16, 2017

View reviewed changes

DeepDiver1975 added the 2 - Developing label Oct 16, 2017

DeepDiver1975 added this to the development milestone Oct 16, 2017

issue-27854

9dc5d2e

added new output added test annotation & check for output

IljaN reviewed Oct 19, 2017

View reviewed changes

IljaN reviewed Oct 20, 2017

View reviewed changes

#27854

3bd61a5

Missing space between if and opening parenthesis annotation phpunit fixed

Gandolf90 changed the title ~~27854 non existing folder skeletondirectory~~ #27854 non existing folder skeletondirectory Oct 22, 2017

Gandolf90 added 4 commits October 24, 2017 13:07

#27854

4c7e476

removed use tag and added path to Exception Class

#27854

26853ea

added user Folde

#27854

da42001

mocked userfolder

#27854

09066b0

#27854

c9f1280

added code style space

Gandolf90 closed this Oct 25, 2017

Gandolf90 deleted the 27854-non-existing-folder-skeletondirectory branch October 28, 2017 09:00

ownclouders added the status/STALE label Dec 20, 2017

lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019


		$skeletonDirectory = \OCP\Config::getSystemValue('skeletondirectory', \OC::$SERVERROOT . '/core/skeleton');

		if(!is_dir($skeletonDirectory)) {

Conversation

Gandolf90 commented Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

CLAassistant commented Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DeepDiver1975 left a comment

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 Oct 16, 2017

Choose a reason for hiding this comment

Uh oh!

DeepDiver1975 commented Oct 16, 2017

Uh oh!

IljaN commented Oct 18, 2017

Uh oh!

IljaN Oct 19, 2017

Choose a reason for hiding this comment

Uh oh!

IljaN Oct 20, 2017

Choose a reason for hiding this comment

Uh oh!

IljaN commented Oct 24, 2017

Uh oh!

Gandolf90 commented Oct 24, 2017

Uh oh!

IljaN commented Oct 25, 2017

Uh oh!

Gandolf90 commented Oct 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IljaN commented Oct 25, 2017

Uh oh!

phil-davis commented Oct 25, 2017

Uh oh!

Gandolf90 commented Oct 25, 2017

Uh oh!

Gandolf90 commented Oct 25, 2017

Uh oh!

IljaN commented Oct 26, 2017

Uh oh!

Gandolf90 commented Oct 26, 2017

Uh oh!

phil-davis commented Oct 26, 2017

Uh oh!

Gandolf90 commented Oct 26, 2017

Uh oh!

Gandolf90 commented Oct 26, 2017

Uh oh!

lock bot commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gandolf90 commented Oct 15, 2017 •

edited

Loading

CLAassistant commented Oct 15, 2017 •

edited

Loading

Gandolf90 commented Oct 25, 2017 •

edited

Loading