[Fix] Added config settings permissions to default groups #664 - #665
Merged
Conversation
nemesifier
reviewed
Jun 21, 2022
| ) | ||
| if operation in operator_operations: | ||
| operator.permissions.add(permission.pk) | ||
| admin.permissions.add(permission.pk) |
Member
There was a problem hiding this comment.
what if the groups already have the permission?
Member
Author
There was a problem hiding this comment.
I tested this case, it doesn't raise any exception if permission is already present.
codesankalp
force-pushed
the
issues/664-config-permissions
branch
from
June 21, 2022 18:48
bdf7a7e to
7a9c5ef
Compare
nemesifier
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664