fix(sandboxing): initialize network proxy config inline - #31830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #31767 flattened
NetworkProxyConfig, leaving the seatbelt test setup to assign fields directly afterNetworkProxyConfig::default(). Rust 1.95 flags that pattern asclippy::field_reassign_with_default, and the macOS Bazel Clippy job treats the warning as an error, blockingmainand PRs based on it.What Changed
Initialize
enabledandmodein theNetworkProxyConfigstruct literal, then apply the Unix socket allowlist through the existing setter. This preserves the test behavior while satisfying Clippy.How to Test
This is a test-only initialization change, so there is no manual product flow.
Targeted tests:
just test -p codex-sandboxing(65 passed)just clippy -p codex-sandboxingThe local argument-comment lint could not complete because Bazel's LLVM repository is missing the
compiler-rtBUILD package. The touched Rust diff was manually audited and adds no positional literal calls.