Skip to content

Remove the network proxy config wrapper - #31767

Merged
jif-oai merged 2 commits into
mainfrom
jif/collapse-network-proxy-config
Jul 9, 2026
Merged

Remove the network proxy config wrapper#31767
jif-oai merged 2 commits into
mainfrom
jif/collapse-network-proxy-config

Conversation

@jif-oai

@jif-oai jif-oai commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

NetworkProxyConfig only wrapped NetworkProxySettings in a single network field. That extra level made runtime callers repeat .network everywhere without representing a real boundary.

What changed

  • move the managed-network fields directly onto NetworkProxyConfig
  • collapse the matching partial-config wrapper
  • update runtime callers and tests to use the direct fields
  • keep the user-facing permissions/profile TOML layout unchanged

The internal serialized shape now matches the runtime type itself. This does not change managed-network behavior or the config.toml shape.

@jif-oai
jif-oai requested a review from a team as a code owner July 9, 2026 10:30
@jif-oai

jif-oai commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: efb3a03108

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jif-oai
jif-oai merged commit cf6d8ad into main Jul 9, 2026
61 of 66 checks passed
@jif-oai
jif-oai deleted the jif/collapse-network-proxy-config branch July 9, 2026 16:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants