test(app-server): use native rollout fixture paths - #31663
Merged
Conversation
canvrno-oai
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows CI now places temporary and build files on the
D:Dev Drive. Fake rollout metadata still stored/as its working directory, but/is drive-relative on Windows. When the migrated auto-environment tests resumed or listed those rollouts, the fixture resolved toD:\while the established test expectation remainedC:\, causing unrelated PRs to fail the Windows app-server shard.This follows the interaction between #31357, which moved CI build paths to the Dev Drive, and #31614, which migrated these app-server tests to automatic environments.
What
test_path_buf("/"), producing a fully qualified native path on Windows while preserving/on Unix.How to Test
Automated tests were intentionally not run locally at request; the app-server suite was stopped during compilation.
just fmtcompleted successfully.To verify the regression on a Windows runner:
TEMPandTMPon a non-C:drive, as CI does with the Dev Drive.just test -p codex-app-server.D:\actual versusC:\expected paths.This is a test-fixture-only change, so there is no product smoke path.