Skip to content

test(app-server): use native rollout fixture paths - #31663

Merged
fcoury-oai merged 1 commit into
mainfrom
codex/fix-windows-auto-env-paths
Jul 8, 2026
Merged

test(app-server): use native rollout fixture paths#31663
fcoury-oai merged 1 commit into
mainfrom
codex/fix-windows-auto-env-paths

Conversation

@fcoury-oai

Copy link
Copy Markdown
Contributor

Why

Windows CI now places temporary and build files on the D: Dev Drive. Fake rollout metadata still stored / as its working directory, but / is drive-relative on Windows. When the migrated auto-environment tests resumed or listed those rollouts, the fixture resolved to D:\ while the established test expectation remained C:\, causing unrelated PRs to fail the Windows app-server shard.

This follows the interaction between #31357, which moved CI build paths to the Dev Drive, and #31614, which migrated these app-server tests to automatic environments.

What

  • Construct fake rollout working directories with test_path_buf("/"), producing a fully qualified native path on Windows while preserving / on Unix.
  • Use the same native test-path helper for the legacy conversation-summary expectation.

How to Test

Automated tests were intentionally not run locally at request; the app-server suite was stopped during compilation. just fmt completed successfully.

To verify the regression on a Windows runner:

  1. Configure TEMP and TMP on a non-C: drive, as CI does with the Dev Drive.
  2. Run just test -p codex-app-server.
  3. Confirm the existing thread list, read, and resume tests no longer report D:\ actual versus C:\ expected paths.

This is a test-fixture-only change, so there is no product smoke path.

@fcoury-oai
fcoury-oai merged commit 4e270dd into main Jul 8, 2026
35 checks passed
@fcoury-oai
fcoury-oai deleted the codex/fix-windows-auto-env-paths branch July 8, 2026 22:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants