Skip to content

test: migrate app-server v2 starts to auto env - #31614

Merged
anp-oai merged 4 commits into
mainfrom
codex/app-server-auto-env-tests
Jul 8, 2026
Merged

test: migrate app-server v2 starts to auto env#31614
anp-oai merged 4 commits into
mainfrom
codex/app-server-auto-env-tests

Conversation

@anp-oai

@anp-oai anp-oai commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

We should be running as many integrations tests as possible against the split cross-OS configuration.

What

  • migrate eligible thread starts and builders to auto env
  • keep explicit custom/local-executor cases local with rationale comments
  • keep auto-env coverage where possible and add narrow TODO(anp) skips for fixtures that are not target-native yet

@anp-oai
anp-oai marked this pull request as ready for review July 8, 2026 19:16
@anp-oai

anp-oai commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 8, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69e48df55d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/tests/suite/v2/executor_skills.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/imagegen_extension.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/turn_interrupt.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/turn_start_zsh_fork.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/turn_steer.rs
Comment thread codex-rs/app-server/tests/suite/v2/turn_start.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/turn_start.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/skills_list.rs Outdated
Comment thread codex-rs/app-server/tests/suite/v2/turn_start.rs
Comment thread codex-rs/app-server/tests/suite/v2/hooks_list.rs
@anp-oai

anp-oai commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 8, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa8d9867f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/tests/suite/v2/turn_start.rs
@anp-oai
anp-oai merged commit 5c7624a into main Jul 8, 2026
35 checks passed
@anp-oai
anp-oai deleted the codex/app-server-auto-env-tests branch July 8, 2026 21:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@sayan-oai sayan-oai sayan-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anp-oai @sayan-oai