-
Notifications
You must be signed in to change notification settings - Fork 15.4k
chore(app-server): mark thread/rollback as deprecated #29928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper is only called from
thread_rollbackabove, so it adds an extra local method for a single straight-line notification send. The codex-rs guidance asks us not to create small helper methods referenced only once; keeping the send inline here avoids unnecessary indirection.AGENTS.md reference: AGENTS.md:L44-L44
Useful? React with 👍 / 👎.