chore(app-server): mark thread/rollback as deprecated - #29928
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15c56f3bd3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map(|()| None) | ||
| } | ||
|
|
||
| async fn send_thread_rollback_deprecation_notice(&self, connection_id: ConnectionId) { |
There was a problem hiding this comment.
This helper is only called from thread_rollback above, so it adds an extra local method for a single straight-line notification send. The codex-rs guidance asks us not to create small helper methods referenced only once; keeping the send inline here avoids unnecessary indirection.
AGENTS.md reference: AGENTS.md:L44-L44
Useful? React with 👍 / 👎.
15c56f3 to
344340b
Compare
We will drop support for this in the near future due to the complexity it introduces.