Skip to content

[codex] Emit implicit skill usage for support reads #29731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexsong-oai merged 2 commits into from
Jun 24, 2026
Merged

[codex] Emit implicit skill usage for support reads #29731

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f925281
Emit implicit skill usage for support reads
alexsong-oai Jun 23, 2026
2b21a8d
Remove flaky skill usage detection test
alexsong-oai Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions codex-rs/core-skills/src/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,16 @@ fn finalize_skill_outcome(
disabled_paths: HashSet<AbsolutePathBuf>,
) -> SkillLoadOutcome {
outcome.disabled_paths = disabled_paths;
let (by_scripts_dir, by_doc_path) =
build_implicit_skill_path_indexes(outcome.allowed_skills_for_implicit_invocation());
// Usage-event detection should see any enabled skill file/script read, even when the
// skill is not model-routable through implicit invocation.
let (by_scripts_dir, by_doc_path) = build_implicit_skill_path_indexes(
outcome
.skills
.iter()
.filter(|skill| outcome.is_skill_enabled(skill))
.cloned()
.collect(),
);
outcome.implicit_skills_by_scripts_dir = Arc::new(by_scripts_dir);
outcome.implicit_skills_by_doc_path = Arc::new(by_doc_path);
outcome
Expand Down
Loading