[codex] Emit implicit skill usage for support reads - #29731
Merged
Conversation
alexsong-oai
force-pushed
the
codex/emit-implicit-skill-usage-events
branch
from
June 23, 2026 21:38
af18dbe to
f925281
Compare
xli-oai
approved these changes
Jun 24, 2026
alexsong-oai
enabled auto-merge (squash)
June 24, 2026 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_implicit_invocation.allow_implicit_invocationfor the model-visible implicit routing list.SKILL.mdis read and whose script is run while implicit invocation is disabled.Root cause
allow_implicit_invocationwas used for both model routing and command-based usage-event detection. That meant support skills likedata-analytics:user-contextcould be read or run by other skills, but those accesses could not emit implicit usage events.Validation
just fmtjust test -p codex-core-skills service::tests::skills_for_config_indexes_usage_detection_for_non_implicit_skillsjust test -p codex-core-skillsnow has the new test passing, but 3 unrelated local tests fail because/Users/alexsong/.agents/skills/test/SKILL.mdis invalid/missing YAML frontmatter.