Skip to content

[codex] Emit implicit skill usage for support reads - #29731

Merged
alexsong-oai merged 2 commits into
mainfrom
codex/emit-implicit-skill-usage-events
Jun 24, 2026
Merged

[codex] Emit implicit skill usage for support reads#29731
alexsong-oai merged 2 commits into
mainfrom
codex/emit-implicit-skill-usage-events

Conversation

@alexsong-oai

Copy link
Copy Markdown
Contributor

Summary

  • Index all enabled skills for command-based usage detection, regardless of allow_implicit_invocation.
  • Preserve allow_implicit_invocation for the model-visible implicit routing list.
  • Add regression coverage for a support/preflight skill whose SKILL.md is read and whose script is run while implicit invocation is disabled.

Root cause

allow_implicit_invocation was used for both model routing and command-based usage-event detection. That meant support skills like data-analytics:user-context could be read or run by other skills, but those accesses could not emit implicit usage events.

Validation

  • just fmt
  • just test -p codex-core-skills service::tests::skills_for_config_indexes_usage_detection_for_non_implicit_skills
  • just test -p codex-core-skills now has the new test passing, but 3 unrelated local tests fail because /Users/alexsong/.agents/skills/test/SKILL.md is invalid/missing YAML frontmatter.

@alexsong-oai
alexsong-oai requested a review from a team as a code owner June 23, 2026 21:37
@alexsong-oai
alexsong-oai force-pushed the codex/emit-implicit-skill-usage-events branch from af18dbe to f925281 Compare June 23, 2026 21:38
@alexsong-oai
alexsong-oai enabled auto-merge (squash) June 24, 2026 08:52
@alexsong-oai
alexsong-oai merged commit f959e7f into main Jun 24, 2026
31 checks passed
@alexsong-oai
alexsong-oai deleted the codex/emit-implicit-skill-usage-events branch June 24, 2026 08:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants