[codex] reject remote images at app-server ingress - #29419
Merged
Conversation
rka-oai
force-pushed
the
codex/reject-remote-image-urls
branch
from
June 22, 2026 17:32
64271e4 to
ab0cfce
Compare
rka-oai
force-pushed
the
codex/reject-remote-image-urls-app-server
branch
4 times, most recently
from
June 22, 2026 19:03
84a485f to
dc3b8f8
Compare
rka-oai
marked this pull request as ready for review
June 22, 2026 19:34
rka-oai
force-pushed
the
codex/reject-remote-image-urls-app-server
branch
from
June 22, 2026 21:05
dc3b8f8 to
b719921
Compare
sayan-oai
reviewed
Jun 22, 2026
sayan-oai
reviewed
Jun 22, 2026
sayan-oai
approved these changes
Jun 22, 2026
sayan-oai
left a comment
Contributor
There was a problem hiding this comment.
some small changes requested, unblocking
rka-oai
force-pushed
the
codex/reject-remote-image-urls
branch
from
June 22, 2026 23:18
1be79bb to
bb63f7d
Compare
rka-oai
force-pushed
the
codex/reject-remote-image-urls-app-server
branch
from
June 22, 2026 23:21
b719921 to
a649686
Compare
rka-oai
enabled auto-merge (squash)
June 22, 2026 23:42
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Stacked on #29417. Review and land that PR first.
Summary
turn/startandturn/steerthread/inject_itemsafter its existing JSON-to-ResponseItemconversion, so each item is deserialized oncethread/resume.historycompatible with legacy history; [codex] replace remote images with model-visible error text #29417 replaces remote images before model inputlocalImageinputsTest plan
just test -p codex-app-server -E 'test(/request_handlers_reject_remote_image_urls|dynamic_tool_remote_image_response_becomes_model_visible_error|dynamic_tool_call_round_trip_sends_content_items_to_model|turn_start_tracks_turn_event_analytics|standalone_image_edit_uses_recent_pathless_image/)'(5 passed)just fix -p codex-app-serverjust fmt