[codex] replace remote images with model-visible error text - #29417
Merged
Conversation
rka-oai
force-pushed
the
codex/reject-remote-image-urls
branch
from
June 22, 2026 17:32
64271e4 to
ab0cfce
Compare
rka-oai
marked this pull request as ready for review
June 22, 2026 17:34
sayan-oai
approved these changes
Jun 22, 2026
rka-oai
force-pushed
the
codex/reject-remote-image-urls
branch
from
June 22, 2026 23:18
1be79bb to
bb63f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR will extend the existing centralized image-preparation path to replace HTTP(S) image inputs with a model visible error message. It won't "ruin" and break existing rollouts, but it will deprecate support for the pathway. App server clients should no longer use HTTP image urls if they'd like to upgrade.
The HTTP image url pathway is currently resolved in the responsesapi. It is slow and not reccomended.
Behavior
input_textThis intentionally does not change app-server ingress. That validation remains a follow-up.
Test plan
just test -p codex-core -E 'test(/image_preparation|prepares_image_failures_before_history_insertion|prepares_resumed_history_before_installing_it|responses_lite_prepares_images/)'— 7 passedjust fix -p codex-corejust fmt