[codex] Round-trip turn state through compact - #27931
Conversation
09cc0ae to
5db8ef1
Compare
1a75dcb to
7ffdd61
Compare
5db8ef1 to
c73a2b3
Compare
7ffdd61 to
8313869
Compare
c73a2b3 to
c9cf1b5
Compare
e4ab789 to
005bb27
Compare
c9cf1b5 to
748b8e1
Compare
005bb27 to
5dd34cc
Compare
748b8e1 to
b05a1ff
Compare
5dd34cc to
62b3bdd
Compare
62b3bdd to
763f6fd
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 763f6fd922
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| &payload, | ||
| extra_headers, | ||
| compact_request_timeout, | ||
| turn_state.as_deref(), |
There was a problem hiding this comment.
Reconnect before sampling with new compact state
When remote compaction runs on a ModelClientSession that already has an open Responses websocket (for example after prewarm or a mid-turn sample), this call stores the compact response's x-codex-turn-state, but websocket_connection later reuses the existing connection and only builds/replays headers when opening a new one. The post-compact sample can therefore continue on the old route instead of using the compact state; reset or reconnect the websocket when compaction updates the turn state.
Useful? React with 👍 / 👎.
|
Closing this stack to replace it with one consolidated PR. |
|
Replaced by #27996. |
Summary
Carry opaque turn state through remote compaction using the active model client session.
Stack
Coverage