[codex] Round-trip model-bound turn state - #27683
Closed
aibrahim-oai wants to merge 1 commit into
Closed
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
x-codex-turn-statetoken to the requested model slugresponse.create.client_metadata, and compact responsesCompanion to backend PR: https://github.com/openai/openai/pull/1018026
Why
WebSocket upgrade headers are connection-scoped, so a reused connection cannot carry the correct per-request turn state. Compact responses also previously dropped the response header. A single unqualified
OnceLockcould retain state from an older requested model during pre-turn compaction.The client now treats response metadata as authoritative, uses a handshake token only after a response attempt produces no metadata, and replaces the state when the requested slug changes.
Validation
cargo check -p codex-corecodex-corerouting/WS/compact suite: 8 passedjust test -p codex-api: 123 passedjust fix -p codex-apicargo fmt --all