code-mode standalone: Cutover to new process - #27727
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15e7cfbbcf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return sibling; | ||
| } | ||
| } | ||
| PathBuf::from(executable_name) |
There was a problem hiding this comment.
Keep code mode working in single-binary installs
When codex-code-mode-host is not installed beside the CLI (for example Cargo installs or single-binary release archives), this falls back to PATH and spawning fails, so code-mode execution regresses from the prior in-process behavior for those CLI install surfaces. guidance
Useful? React with 👍 / 👎.
d1b3292 to
08ebec8
Compare
08ebec8 to
181bcfe
Compare
181bcfe to
c1bf7b7
Compare
c1bf7b7 to
32ed022
Compare
Compare with previous
This is phase 3 of a 4 phase stack:
CodeModeSessionProviderto use new binary code-mode standalone: Add client and consume with packaging #27726Complete the process isolation and remove V8 from the core dependency graph.