code-mode standalone: extract protocol and add host crate - #27724
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 131d87aefc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2607455 to
7f78a47
Compare
|
|
||
| /// A durable code-mode session owned by one Codex thread. | ||
| /// | ||
| /// Cells executed in the same session share stored values. Separate sessions |
There was a problem hiding this comment.
For my own understanding: are we going to allow multiple sessions in the same OS process, or will they have process isolation from each other?
| /// | ||
| /// Remote implementations should return `false` after their underlying | ||
| /// connection fails so callers can create a fresh session for later work. | ||
| fn is_alive(&self) -> bool { |
There was a problem hiding this comment.
nit: IME default trait methods often end up with surprising missing implementations, is there anything that could go wrong if a caller forgets to implement this?
d19fd4b to
79d913b
Compare
This is phase 1 of a 4 phase stack:
CodeModeSessionProviderto use new binaryAdd protocol and host crates for new IPC code mode implementation
Establish a clean process boundary without changing the existing in-process behavior.