feat: use encrypted local secrets for MCP OAuth - #27541
Merged
Merged
Conversation
celia-oai
marked this pull request as ready for review
June 11, 2026 04:56
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e606b34c96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
aibrahim-oai
approved these changes
Jun 11, 2026
celia-oai
force-pushed
the
codex/encrypted-cli-auth-storage
branch
3 times, most recently
from
June 12, 2026 20:58
b8c2e75 to
d43079b
Compare
celia-oai
force-pushed
the
codex/encrypted-mcp-oauth
branch
from
June 12, 2026 21:18
e606b34 to
bf3d667
Compare
celia-oai
force-pushed
the
codex/encrypted-mcp-oauth
branch
from
June 12, 2026 21:29
bf3d667 to
bc08fad
Compare
celia-oai
enabled auto-merge (squash)
June 12, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
This is a parallel review stack; the original #17931 remains unchanged.
Tests
just test -p codex-rmcp-client(the transport round-trip test passed after building the requiredcodexbinary and retrying)just test -p codex-mcpjust test -p codex-app-server refresh_config_uses_latest_auth_keyring_backendjust test -p codex-core refresh_mcp_servers_is_deferred_until_next_turnjust test -p codex-cli mcpjust fix -p codex-rmcp-client -p codex-mcp -p codex-core -p codex-cli -p codex-app-server -p codex-protocoljust bazel-lock-check