feat: add secret auth storage configuration - #27504
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff8f62e2a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jun 11, 2026
bolinfest
reviewed
Jun 11, 2026
bolinfest
reviewed
Jun 12, 2026
| /// | ||
| /// This is intended for startup paths that must read auth before managed cloud | ||
| /// requirements can be loaded and before a full [`Config`] exists. | ||
| pub fn resolve_bootstrap_auth_keyring_backend_kind( |
Collaborator
There was a problem hiding this comment.
Should this be in the mod.rs for the crate? This feels more appropriate to define in some other file within this directory and then export it via mod.rs.
bolinfest
approved these changes
Jun 12, 2026
This was referenced Jun 12, 2026
celia-oai
force-pushed
the
codex/secret-auth-storage-config
branch
from
June 12, 2026 18:53
683a9f4 to
3e3379b
Compare
celia-oai
enabled auto-merge (squash)
June 12, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Windows Credential Manager limits generic credential blobs to 2,560 bytes. The encrypted local secrets backend avoids storing large serialized auth payloads directly in the OS keyring, but selecting that backend needs an independently reviewable feature/config layer before the auth and secrets implementation is wired in.
What Changed
secret_auth_storagefeature, enabled by default on Windows and disabled by default elsewhere.AuthKeyringBackendKindand config resolution for full and bootstrap config loading.This is the base PR for #17931. The auth, secrets, MCP, CLI, TUI, and app-server implementation remains in that follow-up PR.
Validation
just test -p codex-featuresjust test -p codex-configjust test -p codex-core resolve_bootstrap_auth_keyring_backend_kind_uses_secret_auth_storage_featurejust write-config-schemajust fix -p codex-coreThe full
just test -p codex-corerun compiled successfully and ran 2,690 tests; 2,589 passed, one was flaky, and 101 environment-sensitive tests failed because this shell injects apyenvrehash warning into command output or because sandboxed subprocesses timed out.