[codex] add cross-platform filesystem adapter coverage - #27454
Merged
Conversation
anp-oai
marked this pull request as ready for review
June 10, 2026 21:56
anp-oai
commented
Jun 10, 2026
anp-oai
force-pushed
the
codex/exec-server-path-uri
branch
from
June 10, 2026 22:22
071132b to
0bdfc22
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
approved these changes
Jun 11, 2026
anp-oai
force-pushed
the
codex/exec-server-path-uri
branch
from
June 11, 2026 17:30
0bdfc22 to
5e77277
Compare
anp-oai
enabled auto-merge (squash)
June 11, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The exec-server's existing filesystem tests only run on
#[cfg(unix)]. We should be running the applicable ones on Windows, and also include the basic filesystem operations that will be modified by migrating toPathUri.What
Split platform-neutral local/remote tests into a shared Unix/Windows suite while keeping the existing
AbsolutePathBufAPI, and add Windows junction canonicalization coverage.