Skip to content

[codex] migrate ExecutorFileSystem paths to PathUri - #27424

Merged
anp-oai merged 1 commit into
mainfrom
codex/exec-server-path-uri-join-parent
Jun 11, 2026
Merged

[codex] migrate ExecutorFileSystem paths to PathUri#27424
anp-oai merged 1 commit into
mainfrom
codex/exec-server-path-uri-join-parent

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Why

We're moving exec-server to use PathUri for its internal path representations.

What

Move ExecutorFileSystem APIs to use PathUri instead of AbsolutePathBuf. Future changes will convert higher-level parts of exec-server.

@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from b7ac56f to 254d73c Compare June 10, 2026 18:12
@anp-oai
anp-oai marked this pull request as ready for review June 10, 2026 19:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 254d73c22a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/exec-server/Cargo.toml Outdated
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from 254d73c to bf1a517 Compare June 10, 2026 20:20
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-env-path-ref branch from 8653c51 to 368c3d8 Compare June 10, 2026 20:20
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from bf1a517 to 4ba8306 Compare June 10, 2026 22:22
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-env-path-ref branch from 368c3d8 to 430031f Compare June 10, 2026 22:22
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from 4ba8306 to f933ab4 Compare June 11, 2026 17:38
@anp-oai
anp-oai requested a review from a team as a code owner June 11, 2026 17:38
@anp-oai anp-oai changed the title [codex] remove ExecutorFileSystem join and parent [codex] migrate ExecutorFileSystem paths to PathUri Jun 11, 2026
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-env-path-ref branch from 430031f to a8e9807 Compare June 11, 2026 18:08
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from f933ab4 to 7d16608 Compare June 11, 2026 18:13
Base automatically changed from codex/exec-server-path-uri-env-path-ref to main June 11, 2026 18:26
Move ExecutorFileSystem filesystem operations onto PathUri while preserving native JSON-RPC filesystem payloads at protocol adapter boundaries. Remove join and parent from the filesystem abstraction in favor of PathUri lexical operations.
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-join-parent branch from 7d16608 to 32d2f04 Compare June 11, 2026 18:31
@anp-oai
anp-oai enabled auto-merge (squash) June 11, 2026 18:43
@anp-oai
anp-oai merged commit b2a4e3b into main Jun 11, 2026
46 checks passed
@anp-oai
anp-oai deleted the codex/exec-server-path-uri-join-parent branch June 11, 2026 18:44
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants