[codex] Outline remaining core ToolExecutor handlers - #27302
Closed
anp-oai wants to merge 1 commit into
Closed
Conversation
anp-oai
force-pushed
the
codex/outline-remaining-core-tool-executor-handlers
branch
from
June 10, 2026 04:01
ab59a6d to
4e310a8
Compare
anp-oai
force-pushed
the
codex/outline-multi-agent-tool-executor-handlers
branch
from
June 10, 2026 04:01
8d24241 to
5a4c7c9
Compare
anp-oai
force-pushed
the
codex/outline-remaining-core-tool-executor-handlers
branch
from
June 10, 2026 04:11
4e310a8 to
8a4f370
Compare
anp-oai
force-pushed
the
codex/outline-multi-agent-tool-executor-handlers
branch
from
June 10, 2026 04:11
5a4c7c9 to
4c0c14b
Compare
Contributor
Author
|
[from Codex]: Collapsed into #27299 after the handler extraction diff became small enough to review as one mechanical prep PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ToolExecutor'sasync_traitusage is a significant contributor to slow debug builds forcodex-coreunit tests. Removing it makes those builds materially faster, but the direct trait flip is easier to review once large handler bodies are outsideToolExecutor::handle.Stacked on #27301, this PR finishes the behavior-preserving core handler preparation before the trait change.
What Changed
Outlined the existing
ToolExecutor::handlebodies into inherent asynchandle_callmethods for the remaining core handlers that still contained substantial trait-method bodies, including code mode, dynamic, plan, permission, tool search, shell, test-sync, list-install, request-user-input, and write-stdin handlers.The trait methods still use
async_traitand now just delegate toself.handle_call(invocation).await.Validation
No new tests; this is a behavior-preserving refactor.