Skip to content

[codex] Outline ToolExecutor handler bodies - #27299

Merged
anp-oai merged 1 commit into
mainfrom
codex/outline-standalone-tool-executor-handlers
Jun 10, 2026
Merged

[codex] Outline ToolExecutor handler bodies#27299
anp-oai merged 1 commit into
mainfrom
codex/outline-standalone-tool-executor-handlers

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Why

We're now discouraging use of async_trait.

Removing use of async_trait from ToolExecutor yields a codex_core debug test build speedup of ~78% (from 227.5s to 50.3s) on my machine.

For ease of reviewing, this is a prefactor to extract trait method implementations to inherent methods. This will prevent changing indentation from creating a huge diff.

What

Outlined existing ToolExecutor::handle bodies into inherent async handle_call methods across core and extension tool handlers.

The trait methods still use async_trait and now delegate to self.handle_call(...).await; handler behavior is unchanged.

Comment thread codex-rs/core/src/tools/handlers/unified_exec/exec_command.rs
@anp-oai
anp-oai force-pushed the codex/outline-standalone-tool-executor-handlers branch 3 times, most recently from d22b79f to 5d2045a Compare June 10, 2026 04:39
@anp-oai anp-oai changed the title [codex] Outline standalone ToolExecutor handlers [codex] Outline ToolExecutor handler bodies Jun 10, 2026
@anp-oai
anp-oai marked this pull request as ready for review June 10, 2026 04:48
@anp-oai
anp-oai requested a review from a team as a code owner June 10, 2026 04:48
@anp-oai
anp-oai force-pushed the codex/outline-standalone-tool-executor-handlers branch 2 times, most recently from 082c606 to d41f9c4 Compare June 10, 2026 05:43
@anp-oai
anp-oai force-pushed the codex/outline-standalone-tool-executor-handlers branch from d41f9c4 to 01a4245 Compare June 10, 2026 16:10
@anp-oai
anp-oai force-pushed the codex/outline-standalone-tool-executor-handlers branch from 01a4245 to dfb5c0c Compare June 10, 2026 16:24
@anp-oai
anp-oai merged commit db531b4 into main Jun 10, 2026
31 checks passed
@anp-oai
anp-oai deleted the codex/outline-standalone-tool-executor-handlers branch June 10, 2026 16:40
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants