[codex] Outline ToolExecutor handler bodies - #27299
Merged
Merged
Conversation
anp-oai
commented
Jun 10, 2026
anp-oai
force-pushed
the
codex/outline-standalone-tool-executor-handlers
branch
3 times, most recently
from
June 10, 2026 04:39
d22b79f to
5d2045a
Compare
This was referenced Jun 10, 2026
anp-oai
marked this pull request as ready for review
June 10, 2026 04:48
anp-oai
force-pushed
the
codex/outline-standalone-tool-executor-handlers
branch
2 times, most recently
from
June 10, 2026 05:43
082c606 to
d41f9c4
Compare
jif-oai
approved these changes
Jun 10, 2026
anp-oai
force-pushed
the
codex/outline-standalone-tool-executor-handlers
branch
from
June 10, 2026 16:10
d41f9c4 to
01a4245
Compare
anp-oai
force-pushed
the
codex/outline-standalone-tool-executor-handlers
branch
from
June 10, 2026 16:24
01a4245 to
dfb5c0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're now discouraging use of
async_trait.Removing use of
async_traitfromToolExecutoryields acodex_coredebug test build speedup of ~78% (from 227.5s to 50.3s) on my machine.For ease of reviewing, this is a prefactor to extract trait method implementations to inherent methods. This will prevent changing indentation from creating a huge diff.
What
Outlined existing
ToolExecutor::handlebodies into inherent asynchandle_callmethods across core and extension tool handlers.The trait methods still use
async_traitand now delegate toself.handle_call(...).await; handler behavior is unchanged.