Skip to content

Remove EnvironmentPathRef - #27281

Closed
anp-oai wants to merge 1 commit into
mainfrom
codex/exec-server-path-uri-env-path-ref
Closed

Remove EnvironmentPathRef#27281
anp-oai wants to merge 1 commit into
mainfrom
codex/exec-server-path-uri-env-path-ref

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Intent: remove the bound exec-server path wrapper before the filesystem migration so the cleanup can land independently.

Implementation: delete EnvironmentPathRef and keep executor skill resources on native AbsolutePathBuf plus their environment id for read routing.

Validation: just test -p codex-skills-extension; just fmt.

@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-api branch from 31eaae7 to 96945c7 Compare June 10, 2026 03:56
@anp-oai
anp-oai marked this pull request as ready for review June 10, 2026 03:59
@anp-oai
anp-oai requested a review from a team as a code owner June 10, 2026 03:59
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-env-path-ref branch from c190ca0 to 012f87b Compare June 10, 2026 04:01
@anp-oai
anp-oai changed the base branch from codex/exec-server-path-uri-api to main June 10, 2026 04:02
@anp-oai
anp-oai marked this pull request as draft June 10, 2026 04:03
@anp-oai
anp-oai marked this pull request as ready for review June 10, 2026 04:06

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 012f87b96c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/exec-server/src/lib.rs
@anp-oai
anp-oai marked this pull request as draft June 10, 2026 04:09
@anp-oai
anp-oai force-pushed the codex/exec-server-path-uri-env-path-ref branch from 012f87b to f14c083 Compare June 10, 2026 04:34
@anp-oai anp-oai changed the title [codex] remove unused EnvironmentPathRef Remove EnvironmentPathRef Jun 10, 2026
@anp-oai

anp-oai commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Collapsed into #27282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant