Skip to content

test(pkg): verify lock dir load count in multi-context builds - #14065

Merged
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-mtswzqpqurvw
Apr 6, 2026
Merged

test(pkg): verify lock dir load count in multi-context builds#14065
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-mtswzqpqurvw

Conversation

@Alizter

@Alizter Alizter commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Add a test showing that the lock dir is currently loaded once per context when contexts share the same lock dir path.

This invariant was introduced in #12758 but not tested.

Depends on #14064.

@Alizter
Alizter marked this pull request as draft April 6, 2026 17:25
@Alizter
Alizter force-pushed the push-mtswzqpqurvw branch from 8ffa945 to 8bdbd94 Compare April 6, 2026 18:56
@Alizter
Alizter marked this pull request as ready for review April 6, 2026 18:56
@Alizter
Alizter requested a review from rgrinberg April 6, 2026 18:57
Comment thread test/blackbox-tests/test-cases/pkg/lock-dir-load-dedup.t Outdated
Add a test showing that the lock dir is currently loaded once per
context even when contexts share the same lock dir path.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Alizter force-pushed the push-mtswzqpqurvw branch from 8bdbd94 to 297f1ad Compare April 6, 2026 20:26
@Alizter
Alizter merged commit 77ad1ca into ocaml:main Apr 6, 2026
30 checks passed
@Alizter
Alizter deleted the push-mtswzqpqurvw branch April 6, 2026 20:40
Alizter added a commit that referenced this pull request Apr 7, 2026
Correctly build and then depend on the internal lock file. We also don't
break the invariant tested in #14065.

- Fixes #13234
- [x] changelog
@Alizter Alizter added this to the 3.23.0 milestone Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants