Skip to content

feat(trace): add load_lock_dir trace event for lock dir loading - #14064

Merged
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-slllrukywkwl
Apr 6, 2026
Merged

feat(trace): add load_lock_dir trace event for lock dir loading#14064
Alizter merged 1 commit into
ocaml:mainfrom
Alizter:push-slllrukywkwl

Conversation

@Alizter

@Alizter Alizter commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Emit a pkg/load_lock_dir trace event with duration around the load function in lock_dir.ml, showing the path.

This will be used for counting how many times a lock directory is loaded in future tests and for checking how long it takes to load a lock directory.

@Alizter
Alizter requested a review from rgrinberg April 6, 2026 17:07
Emit a pkg/load_lock_dir trace event with duration around
the load function in lock_dir.ml, showing the path.

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Alizter merged commit c4159de into ocaml:main Apr 6, 2026
29 checks passed
@Alizter
Alizter deleted the push-slllrukywkwl branch April 6, 2026 18:55
Alizter added a commit that referenced this pull request Apr 6, 2026
Add a test showing that the lock dir is currently loaded once per
context when contexts share the same lock dir path.

This invariant was introduced in #12758 but not tested.

Depends on #14064.
@Alizter Alizter added this to the 3.23.0 milestone Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants