Consolidate driver and test driver codebases#397
Merged
bryevdv merged 18 commits intonv-legate:branch-22.12from Oct 5, 2022
bryevdv:bv/test-driver-pr
Merged
Consolidate driver and test driver codebases#397bryevdv merged 18 commits intonv-legate:branch-22.12from bryevdv:bv/test-driver-pr
bryevdv merged 18 commits intonv-legate:branch-22.12from
bryevdv:bv/test-driver-pr
Conversation
manopapad
approved these changes
Oct 5, 2022
magnatelee
approved these changes
Oct 5, 2022
Contributor
Author
cc @trxcllnt |
Member
|
Yeah, I tried with installing directly into the conda env and everything works with just |
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Add more checks on user errors to the attach APIs * Fix the multi-attachment check and address review comments * Make the color collision check less expensive * Fix the clang-tidy error and address the review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all of the test driver code in
nv-legate/cumericdown into this repo tolegate.tester. Where possible classes and functions that were similar or duplicated between the two were moved into a new legate.util` module.Downstream changes
The changes required to have Cunumeric's
test.pywork are given below. I will make a corresponding PR there that also removes the old tester codebase there as well.It's possible (likely) that the tester code will need to be generalized, especially with respect to the ability to specify test locations and files maybe even types of test. I think its best to keep this PR simple and wait until we want to add a concrete second project for testing, and generalize based on those requirements.
Self-testing
The new submodules in legate core have ~1220 tests. I would like to get these running in CI at some point. These tests can be run with "plain" pytest, I think that is important otherwise the test code is testing itself in a sense.