Skip to content

Support python coverage test.#649

Closed
robinwnv wants to merge 1 commit intonv-legate:branch-22.12from
robinwnv:enable_coverage_test
Closed

Support python coverage test.#649
robinwnv wants to merge 1 commit intonv-legate:branch-22.12from
robinwnv:enable_coverage_test

Conversation

@robinwnv
Copy link
Contributor

If we specify --cov_bin, it will run legate command with "coverage run". coverage here is a python module which measures python source code coverage.
e.g.:
./test.py --use=cuda --cov_bin /home/robinw/miniconda3/envs/legate/bin/coverage --cov_src_path /home/robinw/legate/cunumeric/cunumeric --debug --verbose

If we don't specify --cov_bin, it will run legate command without "coverage run" as before.
./test.py --use=cuda --debug --verbose

@robinwnv robinwnv added the category:task PR is a simple task and will not be included in release notes label Oct 10, 2022
@robinwnv robinwnv requested a review from bryevdv October 10, 2022 09:53
@bryevdv
Copy link
Contributor

bryevdv commented Oct 10, 2022

@robinw0928 You will need to close this and re-open against legate.core. All the test code moved there in nv-legate/legate#397 I was going to merge the cunumeric side of that work #627 late last week but some build issues came up. I will try to get it merged today.

+ [str(test_path)]
)
else:
cmd = [str(config.legate_path), str(test_path)]
Copy link
Contributor

@bryevdv bryevdv Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also when you do move this to the legate repo, please change this to leave cmd the way it is. Construct the cov args in a method self.cov_args, similar to stage, file args, etc. and then add them to cmd in the line just below in the same way. Then there can be a test added to verify that cov_args are being constructed correctly.

@bryevdv
Copy link
Contributor

bryevdv commented Oct 10, 2022

@robinw0928 #627 has been merged

@bryevdv
Copy link
Contributor

bryevdv commented Oct 12, 2022

@robinw0928 I see you have submitted nv-legate/legate#431 I will go ahead and close this PR

@bryevdv bryevdv closed this Oct 12, 2022
@robinwnv robinwnv deleted the enable_coverage_test branch March 14, 2023 08:45
manopapad added a commit that referenced this pull request Mar 17, 2025
mag1cp1n pushed a commit to mag1cp1n/cupynumeric that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:task PR is a simple task and will not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants