Skip to content

Enhance test_put_along_axis, test_take_along_axis.#671

Merged
robinwnv merged 4 commits intonv-legate:branch-22.12from
robinwnv:enhance_take_put_along_axis
Nov 1, 2022
Merged

Enhance test_put_along_axis, test_take_along_axis.#671
robinwnv merged 4 commits intonv-legate:branch-22.12from
robinwnv:enhance_take_put_along_axis

Conversation

@robinwnv
Copy link
Contributor

No description provided.

@robinwnv robinwnv added the category:task PR is a simple task and will not be included in release notes label Oct 26, 2022
@robinwnv robinwnv requested a review from ipdemes October 26, 2022 09:10
@manopapad
Copy link
Contributor

Can you merge from latest branch-22.12, and trigger the CI again? The OpenMP failure may be because of an issue that Irina fixed with #665.

@ipdemes
Copy link
Contributor

ipdemes commented Oct 28, 2022

I left a couple of minor comments, it looks good otherwise.
I will create a separate PR that fixes all issues found in the test and remove xfails

@ipdemes
Copy link
Contributor

ipdemes commented Oct 28, 2022

Please update you branch with branch-22.12 and feel free to merge it when CI passes

@ipdemes
Copy link
Contributor

ipdemes commented Oct 31, 2022

@robinw0928 : feel free to merge this PR

@robinwnv robinwnv merged commit 63e6206 into nv-legate:branch-22.12 Nov 1, 2022
@robinwnv robinwnv deleted the enhance_take_put_along_axis branch March 14, 2023 08:45
mag1cp1n pushed a commit to mag1cp1n/cupynumeric that referenced this pull request Apr 11, 2025
The git SHA and build number should be at the end of the build string, the build number is especially important in assisting the solver in resolving the latest version that should be installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:task PR is a simple task and will not be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants