Following on comments for PUT#665
Merged
ipdemes merged 7 commits intonv-legate:branch-22.12from Oct 26, 2022
Merged
Conversation
manopapad
reviewed
Oct 25, 2022
src/cunumeric/index/zip_omp.cc
Outdated
| new_point[i] = compute_idx(indx_ptrs[i][idx], shape[i]); | ||
| auto pair = compute_idx_omp(indx_ptrs[i][idx], shape[i]); | ||
| new_point[i] = pair.first; | ||
| is_out_of_bounds = is_out_of_bounds || pair.second; |
Contributor
There was a problem hiding this comment.
Can we switch this snippet to something like:
if (pair.second) is_out_of_bounds = true;
This way we only actually do the atomic write if the flag is true, which should be a very rare occurrence.
Similar for other cases where we set an "out-of-bounds" flag in an OpenMP task, including for wrap.
Contributor
Author
There was a problem hiding this comment.
makes sense. pushing the change
manopapad
approved these changes
Oct 26, 2022
mag1cp1n
pushed a commit
to mag1cp1n/cupynumeric
that referenced
this pull request
Apr 22, 2025
* add setting for cupynu doctor mode * fix type for Checkup.reference * cls var for threshhold * CheckupInfo -> Diagnostic * bump legate hash * update hash again * add option for full traceback * treat scalar key test more carefully * Apply suggestions from code review Co-authored-by: Manolis Papadakis <manopapad@gmail.com> * check repeated item ops per line * check repeated item ops per line * filter internal hits * single list for json output * add reference * docs * typos --------- Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
-fixes issue with raising error inside of the tmp kernel
-renames variables in wrap
-checking bounds in wrap only when mode ==
raise