Testcase add test cases for test_tile.py and test_repeat.py#645
Closed
XiaLuNV wants to merge 39 commits intonv-legate:branch-22.10from
Closed
Testcase add test cases for test_tile.py and test_repeat.py#645XiaLuNV wants to merge 39 commits intonv-legate:branch-22.10from
XiaLuNV wants to merge 39 commits intonv-legate:branch-22.10from
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Run CI every 4 hours in addition to commit-triggered runs. Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
…-legate#620) (nv-legate#637) This file was included unnecessarily, and led to build issues on distributed machines. In particular, including coll.h pulls in mpi.h, which is an unresolved header to NVCC. Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Marcin Zalewski <mzalewski@nvidia.com>
bryevdv
reviewed
Oct 19, 2022
| - gh-pages # deployment target branch (this workflow should not exist on that branch anyway) | ||
| schedule: | ||
| # * is a special character in YAML so you have to quote this string | ||
| - cron: '0 */6 * * *' |
Contributor
There was a problem hiding this comment.
This change seems unrelated to adding test cases, is there a discussion somewhere regarding adding a timed schedule for CI to run?
Contributor
Author
There was a problem hiding this comment.
I give up this PR, and all related commits are in this PR: #657. In the new PR, this file has not been changed.
| def test_array_empty_repeats_invalid(repeats): | ||
| # numpy raises: | ||
| # ValueError: operands could not be broadcast together with shape (0,) (2,) | ||
| # while cunumeric is pass with the result [] |
Contributor
There was a problem hiding this comment.
Add xfail test for discrepancy? (here and other places)
Contributor
Author
There was a problem hiding this comment.
I give up this PR, and all related commits are in this PR: #657. This function was fixed.
Contributor
There was a problem hiding this comment.
Sure, in that case please close
Contributor
|
@xialu00 sorry, I think this PR dropped off my radar. I've left a few comments |
Contributor
Author
|
Close this PR because all related commits are in PR #657. |
mag1cp1n
pushed a commit
to mag1cp1n/cupynumeric
that referenced
this pull request
Apr 11, 2025
Also pet-peeve; rename all static-registration variables to align
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testcase add test cases for test_tile.py and test_repeat.py