src/cunumeric/matrix: stop including coll.h in solve_template.inl#620
Merged
rohany merged 2 commits intonv-legate:branch-22.10from Sep 30, 2022
Merged
src/cunumeric/matrix: stop including coll.h in solve_template.inl#620rohany merged 2 commits intonv-legate:branch-22.10from
rohany merged 2 commits intonv-legate:branch-22.10from
Conversation
magnatelee
approved these changes
Sep 29, 2022
This file was included unnecessarily, and led to build issues on distributed machines. In particular, including coll.h pulls in mpi.h, which is an unresolved header to NVCC. Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu>
482683a to
4afdcf9
Compare
magnatelee
pushed a commit
to magnatelee/cunumeric
that referenced
this pull request
Sep 30, 2022
…-legate#620) This file was included unnecessarily, and led to build issues on distributed machines. In particular, including coll.h pulls in mpi.h, which is an unresolved header to NVCC. Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu> Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu>
magnatelee
added a commit
that referenced
this pull request
Sep 30, 2022
…) (#637) This file was included unnecessarily, and led to build issues on distributed machines. In particular, including coll.h pulls in mpi.h, which is an unresolved header to NVCC. Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu> Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Don't share the dependency file. * Disable Nightly verification. * Remove the nightly-exists job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file was included unnecessarily, and led to build issues on distributed machines. In particular, including coll.h pulls in mpi.h, which is an unresolved header to NVCC.