Handle the case where LAPACK_*potrf is a macro, not a function (#527)#539
Merged
marcinz merged 1 commit intonv-legate:branch-22.07from Aug 17, 2022
Merged
Conversation
…gate#527) This is working around some recent changes to OpenBLAS. Previously we were using the internal names for functions, e.g. "spotrf_". OpenBLAS changed the definitions of these internal functions, so in a previous PR we switched to using the public functions, e.g. "LAPACK_spotrf". These used to be function symbols, but in the latest update OpenBLAS changed these to be macros.
manopapad
approved these changes
Aug 16, 2022
manopapad
pushed a commit
that referenced
this pull request
Feb 18, 2025
* update test_clip for np2 * missing comparison * Apply suggestions from code review Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com> --------- Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #527 into branch 22.07.