Handle the case where LAPACK_*potrf is a macro, not a function#527
Merged
manopapad merged 1 commit intonv-legate:branch-22.10from Aug 16, 2022
Merged
Handle the case where LAPACK_*potrf is a macro, not a function#527manopapad merged 1 commit intonv-legate:branch-22.10from
manopapad merged 1 commit intonv-legate:branch-22.10from
Conversation
This is working around some recent changes to OpenBLAS. Previously we were using the internal names for functions, e.g. "spotrf_". OpenBLAS changed the definitions of these internal functions, so in a previous PR we switched to using the public functions, e.g. "LAPACK_spotrf". These used to be function symbols, but in the latest update OpenBLAS changed these to be macros.
magnatelee
approved these changes
Aug 16, 2022
marcinz
pushed a commit
to marcinz/cunumeric
that referenced
this pull request
Aug 16, 2022
…gate#527) This is working around some recent changes to OpenBLAS. Previously we were using the internal names for functions, e.g. "spotrf_". OpenBLAS changed the definitions of these internal functions, so in a previous PR we switched to using the public functions, e.g. "LAPACK_spotrf". These used to be function symbols, but in the latest update OpenBLAS changed these to be macros.
sbak5
pushed a commit
to sbak5/cunumeric
that referenced
this pull request
Aug 17, 2022
…gate#527) This is working around some recent changes to OpenBLAS. Previously we were using the internal names for functions, e.g. "spotrf_". OpenBLAS changed the definitions of these internal functions, so in a previous PR we switched to using the public functions, e.g. "LAPACK_spotrf". These used to be function symbols, but in the latest update OpenBLAS changed these to be macros.
marcinz
added a commit
that referenced
this pull request
Aug 17, 2022
…#539) This is working around some recent changes to OpenBLAS. Previously we were using the internal names for functions, e.g. "spotrf_". OpenBLAS changed the definitions of these internal functions, so in a previous PR we switched to using the public functions, e.g. "LAPACK_spotrf". These used to be function symbols, but in the latest update OpenBLAS changed these to be macros. Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
manopapad
pushed a commit
that referenced
this pull request
Feb 18, 2025
…ith the sha (#527) * update repo name for legate * update repo name for legate * update repo name for legate * update repo name for legate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is working around some recent changes to OpenBLAS. Previously we were using
the internal names for functions, e.g. "spotrf_". OpenBLAS changed the
definitions of these internal functions, so in a previous PR we switched to
using the public functions, e.g. "LAPACK_spotrf". These used to be function
symbols, but in the latest update OpenBLAS changed these to be macros.