added extract and place via advanced indexing#536
Merged
mfoerste4 merged 15 commits intonv-legate:branch-22.10from Aug 25, 2022
Merged
added extract and place via advanced indexing#536mfoerste4 merged 15 commits intonv-legate:branch-22.10from
mfoerste4 merged 15 commits intonv-legate:branch-22.10from
Conversation
Contributor
|
@mfoerste4 : please fix mypy errors |
Contributor
|
Also, you might want to move |
ipdemes
approved these changes
Aug 17, 2022
magnatelee
reviewed
Aug 19, 2022
Contributor
|
@mfoerste4 the numpy doc says |
ipdemes
reviewed
Aug 22, 2022
ipdemes
reviewed
Aug 22, 2022
ipdemes
reviewed
Aug 22, 2022
ipdemes
reviewed
Aug 22, 2022
Contributor
Author
|
@ipdemes, I have added your suggestions. Please have a look at the latest changes. |
ipdemes
approved these changes
Aug 25, 2022
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Sep 2, 2022
* added extract via nonzero and advanced indexing * make mypy happy * move tests to different suite * add extract to doc * skipping nonzero call in favor of astype(bool) * added np.place API, extended test * review suggestions place * fix copy paste * fix copy paste.. * deal with count_nontero non-int return value
manopapad
pushed a commit
that referenced
this pull request
Feb 18, 2025
* Pass github refname (PR Id) to upload in gh-legate-ci * Pass ref_name and default_branch to legate-gh-ci setup. * Use legate-gh-ci v1.23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires #504 to be merged first!
It also requires a solution for #548 (already merged by @magnatelee )