fixing advanced indexing operation for empty arrays#504
Merged
ipdemes merged 16 commits intonv-legate:branch-22.10from Aug 22, 2022
Merged
fixing advanced indexing operation for empty arrays#504ipdemes merged 16 commits intonv-legate:branch-22.10from
ipdemes merged 16 commits intonv-legate:branch-22.10from
Conversation
d02073e to
20f4bed
Compare
25535a1 to
bb89577
Compare
Contributor
Author
|
This PR also fixes |
manopapad
reviewed
Aug 12, 2022
manopapad
reviewed
Aug 12, 2022
ipdemes
commented
Aug 18, 2022
ipdemes
commented
Aug 18, 2022
ipdemes
commented
Aug 18, 2022
ipdemes
commented
Aug 18, 2022
manopapad
reviewed
Aug 19, 2022
manopapad
reviewed
Aug 19, 2022
manopapad
reviewed
Aug 19, 2022
manopapad
reviewed
Aug 19, 2022
manopapad
reviewed
Aug 19, 2022
bryevdv
reviewed
Aug 19, 2022
manopapad
approved these changes
Aug 19, 2022
Contributor
manopapad
left a comment
There was a problem hiding this comment.
Great job fixing this very stupid corner case
Contributor
Author
|
Thank you, Manolis! Will merge it after CI passes |
jjwilke
pushed a commit
to jjwilke/cunumeric
that referenced
this pull request
Sep 2, 2022
fixing advanced indexing operation for empty arrays
manopapad
pushed a commit
that referenced
this pull request
Nov 17, 2024
XiaLuNV
pushed a commit
to XiaLuNV/cunumeric
that referenced
this pull request
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes test cases when input/index and/or values are empty arrays
It depends on nv-legate/legate#319 to me merged first