Skip to content

fix: pass headers to test kit server #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigith merged 1 commit into from
Apr 17, 2024
Merged

fix: pass headers to test kit server #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/src/main/java/io/numaproj/numaflow/examples/sink/simple/SimpleSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public ResponseList processMessages(DatumIterator datumIterator) {
}
try {
String msg = new String(datum.getValue());
log.info("Received message: {}", msg);
log.info("Received message: {}, headers - {}", msg, datum.getHeaders());
responseListBuilder.addResponse(Response.responseOK(datum.getId()));
} catch (Exception e) {
responseListBuilder.addResponse(Response.responseFailure(
Expand Down
2 changes: 2 additions & 0 deletions examples/src/test/java/io/numaproj/numaflow/examples/server/ServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.time.Instant;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;

@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
@Slf4j
Expand Down Expand Up @@ -175,6 +176,7 @@ public void testSinkServerInvocation() {
.builder()
.id("id-" + i)
.value(("value-" + i).getBytes())
.headers(Map.of("test-key", "test-value"))
.build());
}

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/io/numaproj/numaflow/mapper/MapperTestKit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import java.time.Instant;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -149,6 +150,7 @@ public MessageList sendRequest(String[] keys, Datum data) {
.setSeconds(data.getWatermark().getEpochSecond())
.setNanos(data.getWatermark().getNano())
.build())
.putAllHeaders(data.getHeaders() == null ? new HashMap<>() : data.getHeaders())
Copy link
Copy Markdown
Contributor

@nagarajatantry nagarajatantry Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it getting initialized if null?

Copy link
Copy Markdown
Contributor Author

@yhl25 yhl25 Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto builder functions throw an exception when we try to assign null values

.build();

try {
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/io/numaproj/numaflow/sinker/SinkerTestKit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import java.io.IOException;
import java.time.Instant;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -164,6 +165,7 @@ public void onCompleted() {
.build() : Timestamp.newBuilder()
.setSeconds(datum.getWatermark().getEpochSecond())
.setNanos(datum.getWatermark().getNano()).build())
.putAllHeaders(datum.getHeaders() == null ? new HashMap<>() : datum.getHeaders())
.build();
requestObserver.onNext(request);
}
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/io/numaproj/numaflow/sourcetransformer/SourceTransformerTestKit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import java.time.Instant;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -158,6 +159,7 @@ public MessageList sendRequest(String[] keys, Datum data) {
.setSeconds(data.getWatermark().getEpochSecond())
.setNanos(data.getWatermark().getNano())
.build())
.putAllHeaders(data.getHeaders() == null ? new HashMap<>() : data.getHeaders())
.build();

try {
Expand Down