Conversation
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
KeranYang
approved these changes
Apr 17, 2024
| .setSeconds(data.getWatermark().getEpochSecond()) | ||
| .setNanos(data.getWatermark().getNano()) | ||
| .build()) | ||
| .putAllHeaders(data.getHeaders() == null ? new HashMap<>() : data.getHeaders()) |
Contributor
There was a problem hiding this comment.
why is it getting initialized if null?
Contributor
Author
There was a problem hiding this comment.
proto builder functions throw an exception when we try to assign null values
Rooknj
approved these changes
Apr 17, 2024
KeranYang
pushed a commit
to KeranYang/numaflow-java
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.