onboard: fix package compile issues - #43
Merged
chaitu236 merged 1 commit intoSep 7, 2023
Merged
Conversation
A recent upstream change to inherit setuptools3-base instead of setuptools caused the compile step to do nothing, which caused the resulting package to be missing many files and be broken. I suspect that change was driven by a desire to eliminate compile warnings about distutils support being deprecated in python 3.12 (the build currently uses python 3.10). This change restores the dependency on distutils and as a result generates the warnings again. This change also restores the gsettings inherit. I suspect that change seemed correct when the compile was unknowingly doing nothing, but is now needed to avoid compile errors. Signed-off-by: Jeffrey Pautler <jeffrey.pautler@ni.com>
chaitu236
requested changes
Sep 7, 2023
chaitu236
approved these changes
Sep 7, 2023
chaitu236
pushed a commit
that referenced
this pull request
May 28, 2026
Drop patch that's included in this release.
Changelog:
v3.2p4 is mainly a bugfix & cleanup release.
Enhancements
Add support for InfernoEmbedded soft-devices (GH-21)
Bug fixes
Fix bug (GH-55) related to split packet (GH-64)
Fix copy paste bug (474f06d)
Add \r to Http header to satisfy RFC2616 specification (GH-20)
Maintenance
build system cleanup (GH-72, GH-27, GH-16)
Fix missing files in source distribution (GH-70, GH-69)
Fix compilation with GCC10 (GH-62)
Minor fixes
Fix typos (GH-43 GH-23)
Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent upstream change to inherit setuptools3-base instead of setuptools caused the compile step to do nothing, which caused the resulting package to be missing many files and be broken.
I suspect that change was driven by a desire to eliminate compile warnings about distutils support being deprecated in python 3.12 (the build currently uses python 3.10). This change restores the dependency on distutils and as a result generates the warnings again.
This change also restores the gsettings inherit. I suspect that change seemed correct when the compile was unknowingly doing nothing, but is now needed to avoid compile errors.