[main] fix(cy): avoid double upload to prevent lock error#6763
Merged
max-nextcloud merged 1 commit intomainfrom Dec 10, 2024
Merged
[main] fix(cy): avoid double upload to prevent lock error#6763max-nextcloud merged 1 commit intomainfrom
max-nextcloud merged 1 commit intomainfrom
Conversation
max-nextcloud
approved these changes
Dec 10, 2024
Collaborator
max-nextcloud
left a comment
There was a problem hiding this comment.
only copyright adjustment was not forward portet - as it's now in a different format all together.
`isolateTest` in `beforeEach` already uploads the file. Uploading it again in the `no actual conflict - just reload` case sometimes led to 423 - Locked responses. Use `cy.createTestDir()` instead and upload only once. Signed-off-by: Max <max@nextcloud.com>
fad03b4 to
79e6709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6760
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.