fix(cy): avoid double upload to prevent lock error#6760
Merged
Conversation
`isolateTest` in `beforeEach` already uploads the file. Uploading it again in the `no actual conflict - just reload` case sometimes led to 423 - Locked responses. Use `cy.createTestDir()` instead and upload only once. Signed-off-by: Max <max@nextcloud.com>
Collaborator
Author
|
https://github.com/nextcloud/text/actions/runs/12233069349/job/34124259796 is an example of a failing job. |
mejo-
approved these changes
Dec 10, 2024
Member
mejo-
left a comment
There was a problem hiding this comment.
Thanks so much for looking into this ❤️
Shall we backport to stable30 and stable29?
Member
|
/backport to stable30 |
Collaborator
Author
This is stable29 😉 I'll trigger backports to main and stable28. |
Collaborator
Author
|
/backport to main |
Collaborator
Author
|
/backport to stable28 |
This was referenced Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isolateTestinbeforeEachalready uploads the file.Uploading it again in the
no actual conflict - just reloadcasesometimes led to 423 - Locked responses.
Use
cy.createTestDir()instead and upload only once.Signed-off-by: Max max@nextcloud.com