Fixed breadcrumbs calculation and actions flow#7478
Conversation
|
In the files app the gallery button is not pushed to the left anymore once you open the sidebar. In the past the button was moved to the left of the sidebar once it was opened. This may be crucial in the future once the sidebar is open per default for wide screens. |
| @@ -21,6 +21,11 @@ | |||
| .actions.creatable { | |||
| position: relative; | |||
There was a problem hiding this comment.
I guess we don't need this anymore.
| display: flex; | ||
| flex: 1 1; | ||
| .button:not(:last-child) { | ||
| margin-right: 3px; |
There was a problem hiding this comment.
any reason for this? AFAICS, it's only applies to button.new, which doesn't need it (#uploadprogresswrapper already has a left margin).
There was a problem hiding this comment.
Yes, in case of other apps want to add their buttons, let them do it without needing to define specific margins :)
There was a problem hiding this comment.
OK, but then you can remove the margin from #uploadprogresswrapper
There was a problem hiding this comment.
also, it should be #controls .button, not .actions.createable
There was a problem hiding this comment.
All buttons should be in the .actions div now. Far better thann having buttons everywhere :)
There was a problem hiding this comment.
perhaps, but definitely not in .createable ;)
|
Should @MorrisJobke 's issue be fixed in this PR as well? I'm made a PR to this branch with a proposed solution to it: #7484 |
MorrisJobke
left a comment
There was a problem hiding this comment.
Together with #7484 this works fine 👍
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
8941bf3 to
3105a27
Compare
Codecov Report
@@ Coverage Diff @@
## master #7478 +/- ##
=========================================
Coverage 51.17% 51.17%
Complexity 24886 24886
=========================================
Files 1602 1602
Lines 94750 94750
Branches 1368 1368
=========================================
Hits 48486 48486
Misses 46264 46264
|
|
Okay, fixed zindex, rebased and seems fine! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
|
Test fixed! There was an issue from #7051.... The test was basically useless ^^ We need to test the tests 😆 EDIT: tests passed! 🎉 |
Needs nextcloud/gallery#336